Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backend lint errors #836

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Fix backend lint errors #836

merged 2 commits into from
Jan 28, 2025

Conversation

rwood-moz
Copy link
Contributor

Backend linting (via ruff check) currently reports: Found 100 errors; update the code (and ruff config where appropriate) to address these lint errors.

@rwood-moz rwood-moz added the testing Issues specific to automated testing label Jan 27, 2025
@rwood-moz rwood-moz linked an issue Jan 27, 2025 that may be closed by this pull request
Fix backend lint errors #835
Closed
@rwood-moz
Copy link
Contributor Author

rwood-moz commented Jan 27, 2025 •
edited
Loading

With this PR:

(venvtest) rwood@Roberts-MacBook-Pro backend % pwd
/Users/rwood/dev/appointment/backend
(venvtest) rwood@Roberts-MacBook-Pro backend % ruff check
All checks passed!

In the future I'll be enabling automatic lint checking in CI (via a different PR/issue #838) to help keep the linting errors at 0 :)

@rwood-moz rwood-moz marked this pull request as ready for review January 27, 2025 21:34
@rwood-moz rwood-moz force-pushed the testing/fix-lint-errors branch from 38acd0b to 7e6e803 Compare January 27, 2025 21:59
MelissaAutumn
MelissaAutumn approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@MelissaAutumn MelissaAutumn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at a glance!

backend/src/appointment/routes/waiting_list.py Outdated Show resolved Hide resolved
@rwood-moz rwood-moz merged commit 0e3596a into main Jan 28, 2025
4 checks passed
@rwood-moz rwood-moz deleted the testing/fix-lint-errors branch January 28, 2025 14:50
@rwood-moz rwood-moz mentioned this pull request Jan 29, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devmount devmount devmount left review comments

@MelissaAutumn MelissaAutumn MelissaAutumn approved these changes

Assignees
No one assigned
Labels
testing Issues specific to automated testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix backend lint errors
3 participants
@rwood-moz @devmount @MelissaAutumn