Tools: Make external-link checker faster #67
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd runs a head check before a get to prevent downloading huge files
codeallthethingz
added
infrastructure
tristanls
reviewed
Nov 25, 2024
| @@ -278,11 +286,28 @@ def check_readme_link(url, rdme): | |||
|
|
|||
|
|
|||
| def check_external_link(url): | |||
| if "openai.com" in url or "science.org" in url: | |||
| return [] | |||
There was a problem hiding this comment.
suggestion (non-blocking): Maybe log a skip here?
| response = requests.head(url, timeout=5, headers=headers) | ||
| if response.status_code < 200 or response.status_code > 299: | ||
| response = requests.get(url, timeout=5, headers=headers) | ||
| except requests.RequestException: |
There was a problem hiding this comment.
issue: This will catch requests.RequestException thrown from requests.get on the line above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the external link checker in the doc sync tool faster.
Because of advanced crawling prevention, it now ignores openai.com and science.org urls.
Added some logging that shows the timing of URLs that take over a second to query.