Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .rsyncignore.local to .gitignore #144

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Add .rsyncignore.local to .gitignore #144

merged 3 commits into from
Jan 17, 2025

Conversation

scottcanoe
Copy link
Contributor

@scottcanoe scottcanoe commented Jan 17, 2025 •
edited
Loading

Note: This PR is primarily aimed at the TBP team.

What

This PR adds rsyncignore.local to .gitignore.

Why

Excluding certain files and folder from rsync's purview shaves off precious seconds when creating EC2 instances. When we run experiments on AWS, an EC2 instance is created for each experiment, which is then updated with local copies of tbp.monty and monty_lab via rsync. Much of rsync's time is spent uploading files that might not be necessary for your particular purposes, such as syncing docs when running an experiment. It would be preferable to prevent user-specific rsync settings from being tracked.

How

A couple of lines were added to .gitignore.

This PR is to accompanied a corresponding change in internal tooling to recognize rsyncignore.local files in tbp.monty.

@scottcanoe scottcanoe marked this pull request as ready for review January 17, 2025 08:55
@scottcanoe scottcanoe added the enhancement New feature or request label Jan 17, 2025
nielsleadholm
nielsleadholm approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@nielsleadholm nielsleadholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and thanks for the clear description of why you opened the PR.

vkakerbeck
vkakerbeck approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@vkakerbeck vkakerbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that's a good idea!

@tristanls tristanls merged commit 307bbc5 into thousandbrainsproject:main Jan 17, 2025
13 checks passed
@tristanls tristanls added the triaged This issue or pull request was triaged label Jan 17, 2025
@scottcanoe scottcanoe deleted the rsyncignore branch January 17, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsleadholm nielsleadholm nielsleadholm approved these changes

@vkakerbeck vkakerbeck vkakerbeck approved these changes

Assignees

@vkakerbeck vkakerbeck

@nielsleadholm nielsleadholm

Labels
enhancement New feature or request triaged This issue or pull request was triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scottcanoe @vkakerbeck @nielsleadholm @tristanls