Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding conceptual illustrations on vison of tbp page #110

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dmsstern
Copy link

Added the illustrations previously discussed - The brain balloons illustration should switch to a night scene when user chooses dark mode (just a fun easter-egg and visual pun). Set the others as half banners because they were otherwise too large for the page.

Copy link

Thank you for your contribution @dmsstern!

It appears that you haven't signed our Contributor License Agreement yet.

Please visit this link and sign.

Note

New signatures are processed during the work week. It may take some time before your signature is processed.

You will be invited to the Numenta nupic-contrib team once your signature is processed.

@vkakerbeck vkakerbeck added documentation Improvements or additions to documentation triaged This issue or pull request was triaged cla Awaiting CLA signature to be processed and removed documentation Improvements or additions to documentation triaged This issue or pull request was triaged labels Dec 12, 2024
Copy link
Contributor

@codeallthethingz codeallthethingz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these amazing illustrations. They're beautiful and I think add a lot to the page.

Some feedback (blocking):

  • HTML - We'd prefer that the images use the markdown format so that people don't have to also learn HTML when editing the docs.
  • Dark Mode: I think we should abandon dark mode for now as getting it to work with readme.com will be a time sink. But we should keep the image for when we do figure it out. :)

Other notes:

  • Image Widths / Floating: There is a PR (Tools: Resize images in markdown  #64) to allow us to change the width of images and once it is merged we can change the image widths that way. For now, having them full screen is probably fine. As that PR is not merged, I may add in the float parameter too which is handy.

@codeallthethingz
Copy link
Contributor

Here is what this page looks like on the preview <3

image

@codeallthethingz
Copy link
Contributor

none blocking comment: The human-like-learning image could be more illustrative of that point. Maybe a baby grasping something rather than the finger touching?

Copy link

Thank you for your contribution @dmsstern!

It appears that you haven't signed our Contributor License Agreement yet.

Please visit this link and sign.

Note

You will be invited to the Thousand Brains Project cla-signatories team once your signature is processed.

Please accept the invitation to complete the CLA process.

@tristanls
Copy link
Contributor

Hi @dmsstern, we updated our CLA signing process, hence the new comment.

@tristanls tristanls mentioned this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Awaiting CLA signature to be processed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants