-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding conceptual illustrations on vison of tbp page #110
base: main
Are you sure you want to change the base?
Conversation
Thank you for your contribution @dmsstern! It appears that you haven't signed our Contributor License Agreement yet. Please visit this link and sign. Note New signatures are processed during the work week. It may take some time before your signature is processed. You will be invited to the Numenta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for these amazing illustrations. They're beautiful and I think add a lot to the page.
Some feedback (blocking):
- HTML - We'd prefer that the images use the markdown format so that people don't have to also learn HTML when editing the docs.
- Dark Mode: I think we should abandon dark mode for now as getting it to work with readme.com will be a time sink. But we should keep the image for when we do figure it out. :)
Other notes:
- Image Widths / Floating: There is a PR (Tools: Resize images in markdown #64) to allow us to change the width of images and once it is merged we can change the image widths that way. For now, having them full screen is probably fine. As that PR is not merged, I may add in the float parameter too which is handy.
none blocking comment: The human-like-learning image could be more illustrative of that point. Maybe a baby grasping something rather than the finger touching? |
Thank you for your contribution @dmsstern! It appears that you haven't signed our Contributor License Agreement yet. Please visit this link and sign. Note You will be invited to the Thousand Brains Project Please accept the invitation to complete the CLA process. |
Hi @dmsstern, we updated our CLA signing process, hence the new comment. |
Added the illustrations previously discussed - The brain balloons illustration should switch to a night scene when user chooses dark mode (just a fun easter-egg and visual pun). Set the others as half banners because they were otherwise too large for the page.