Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add cla label to faciliate pull request triage #108

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

tristanls
Copy link
Contributor

@tristanls tristanls commented Dec 9, 2024

This Pull Request documents an update to the Maintainer triage process.

We do not move forward with Pull Requests until the CLA signature is processed and the CLA check passes. Maintainers are instructed to apply the cla label and skip triage until the CLA check passes. The change here updates the triage process to consist of two phases:

  1. Review pull requests that are pending CLA
  2. Triage pull requests with CLA check passing

Requesting all Maintainers to review as this is a triage process change.

@tristanls tristanls added documentation Improvements or additions to documentation triaged This issue or pull request was triaged labels Dec 9, 2024
Copy link
Contributor

@codeallthethingz codeallthethingz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tristanls
Copy link
Contributor Author

FWIW, in the future, the CLA check can apply and remove the label automatically. But until that code is implemented, I wanted to document that we should be applying the label.

Copy link

@hlee9212 hlee9212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have read and understood the update (and thanks for adding the labels already).

Copy link
Contributor

@vkakerbeck vkakerbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this

Copy link
Contributor

@nielsleadholm nielsleadholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

Copy link
Contributor

@scottcanoe scottcanoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tristanls tristanls merged commit a39a265 into thousandbrainsproject:main Dec 10, 2024
13 checks passed
@tristanls tristanls deleted the triage_and_cla branch December 10, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation triaged This issue or pull request was triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants