Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics about pg dump creation status #215

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

pacospace
Copy link
Contributor

Signed-off-by: Francesco Murdaca [email protected]

Related Issues and Dependencies

Related-To: thoth-station/metrics-exporter#821

@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 28, 2022
Copy link
Contributor

@fridex fridex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM 👍🏻 💯

app.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
Copy link
Contributor

@fridex fridex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏻
thanks!

@sesheta
Copy link
Member

sesheta commented Jan 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2022
@sesheta sesheta merged commit 2ca805b into thoth-station:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants