Fix parsing solver name for Python 3.10 #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesheta
added
the
size/XS
KPostOffice
reviewed
Feb 3, 2022
thoth/common/openshift.py
Outdated
| @@ -217,7 +217,7 @@ def parse_python_solver_name(cls, solver_name: str) -> Dict[str, Any]: | |||
| f"Python version encoded into Python solver name does not start with 'py' prefix: {solver_name!r}" | |||
| ) | |||
|
|
|||
| python_version = ".".join(list(python_version)) | |||
| python_version = python_version[0] + "." + python_version[1:] | |||
There was a problem hiding this comment.
Can you use f-string instead of concatenation?
fridex
force-pushed
the
fix-parsing-solver-name-py310
branch
from
3a79f6e to
8aaaab5
Compare
|
/approve |
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fridex, harshad16, KPostOffice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues and Dependencies
Related: thoth-station/s2i-thoth#231 (comment)
This introduces a breaking change