Binding specific ip to irc connection #141
Conversation
Add ip bind function (var myhost)
Added host bind option for irc connection, var myhost
| "crypto/tls" | ||
| "log" | ||
| "os" | ||
|
|
||
| irc "github.com/kofany/go-ircevent" |
| "crypto/tls" | ||
| "fmt" | ||
|
|
||
| irc "github.com/kofany/go-ircevent" |
| @@ -1,6 +1,6 @@ | |||
| module github.com/thoj/go-ircevent | |||
| module github.com/kofany/go-ircevent | |||
There was a problem hiding this comment.
Do not change the module name
There was a problem hiding this comment.
I change as I use fork in my project
irc.go
Outdated
|
|
||
| return nil | ||
| } | ||
|
|
||
| // Create a connection with the (publicly visible) nickname and username. | ||
| // The nickname is later used to address the user. Returns nil if nick | ||
| // or user are empty. | ||
| func IRC(nick, user string) *Connection { | ||
| func IRC(nick, user string, myhost string) *Connection { |
There was a problem hiding this comment.
This breaks backwards compatibility.
There was a problem hiding this comment.
Sorry I add this functionality for my own project and im not pro in go, I try to find a better solution for this future.
Maybe you can suggest the way?
irc_callback.go
Outdated
| if irc.nickcurrent == "" { | ||
| irc.nickcurrent = irc.nick | ||
| } | ||
| if len(irc.nickcurrent) > 8 { | ||
| irc.nickcurrent = "_" + irc.nickcurrent | ||
| } else { | ||
| irc.nickcurrent = irc.nickcurrent + "_" | ||
| } |
There was a problem hiding this comment.
I would create a function for this, the exact same code is used four times.
There was a problem hiding this comment.
I will try to do that in my next code update for this fork.
irc_callback.go
Outdated
| irc.Lock() | ||
| defer irc.Unlock() | ||
| if !irc.fully_connected { | ||
| // Zachowaj obecny nick i nie podejmuj kolejnej próby zmiany |
There was a problem hiding this comment.
Will be fixed also, like I said before go is new for me (working with git pull/push also :P)
fully_connected to fullyConnected name change Co-authored-by: Iceflower <[email protected]>
myhost to host name change Co-authored-by: Iceflower <[email protected]>
|
Nów it should be backward compatible as of tag/release v0.1.4 of my fork |
No description provided.