Add some comments in conjugate_quad(a::AbsSimpleNumFieldElem) #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1653 +/- ##
==========================================
- Coverage 75.86% 75.85% -0.02%
==========================================
Files 361 361
Lines 113687 113688 +1
==========================================
- Hits 86253 86239 -14
- Misses 27434 27449 +15
|
thofma
reviewed
Oct 18, 2024
Comment on lines
+927
to
+928
| # The C type `nf_elem_t` (corresponding to `AbsSimpleNumFieldElem`) starts with | ||
| # an `fmpq_poly_t` (our `QQPolyRingElem`). |
There was a problem hiding this comment.
I am not sure that this is true, since the quadratic case is handled differently: https://github.com/flintlib/flint/blob/main/src/nf_elem.h#L49.
There was a problem hiding this comment.
Indeed, it may be wrong. I'll update it once I find the time.
(Just to explain how this PR came about: I converted ccalls in Hecke to use the new Nemo helpers like set!, but the code in here really confused the hell out of me, so I tried to untangle it... at some point I decided it's not worth it right now to try to convert it, but thought that perhaps my comments would still be helpful.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.