More functionality for sparse matrices and rows #1221
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
can_solve
by only doing parts ofcan_solve_with_solution
Matrix(::SMat)
andArray(::SMat)
to their docstrings (and move them to the same place). This changed them from returning a AA MatElem to a julia Matrix.Vector(::SRow)
SRow
<->MatElem
conversion from Oscar here. This can then be deleted afterwards in Oscar.One could consider 2 above breaking, but I would instead call that a bugfix, as the intended behaviour described in the docstring didn't change.
It would be great if I could get a release shortly after merging this to be able to use it in Oscar.LieAlgebras.