Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More functionality for sparse matrices and rows #1221

Merged
merged 9 commits into from
Sep 21, 2023

Conversation

lgoettgens
Copy link
Contributor

@lgoettgens lgoettgens commented Sep 21, 2023

Changes:

  1. Add can_solve by only doing parts of can_solve_with_solution
  2. Adapt Matrix(::SMat) and Array(::SMat) to their docstrings (and move them to the same place). This changed them from returning a AA MatElem to a julia Matrix.
  3. Add a similar function Vector(::SRow)
  4. Copy the SRow <-> MatElem conversion from Oscar here. This can then be deleted afterwards in Oscar.
  5. Allow scalar multiplication from left and from right, and widen signature.

One could consider 2 above breaking, but I would instead call that a bugfix, as the intended behaviour described in the docstring didn't change.
It would be great if I could get a release shortly after merging this to be able to use it in Oscar.LieAlgebras.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 82.27% and project coverage change: +0.09% 🎉

Comparison is base (9de3b38) 74.36% compared to head (d9ca7a5) 74.45%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1221      +/-   ##
==========================================
+ Coverage   74.36%   74.45%   +0.09%     
==========================================
  Files         346      346              
  Lines      110757   110806      +49     
==========================================
+ Hits        82361    82504     +143     
+ Misses      28396    28302      -94     
Files Changed Coverage Δ
src/NumField/NfRel/NfRelNS.jl 84.87% <ø> (+1.34%) ⬆️
src/Sparse/Solve.jl 85.97% <58.82%> (-1.77%) ⬇️
src/Sparse/Row.jl 83.03% <80.00%> (-0.52%) ⬇️
src/Sparse/Matrix.jl 63.98% <100.00%> (+1.66%) ⬆️

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thofma thofma merged commit d23dfff into thofma:master Sep 21, 2023
14 of 16 checks passed
@lgoettgens lgoettgens deleted the lg/sparse branch September 21, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants