Fix trace equivalence for infinite isometries #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1212 +/- ##
==========================================
- Coverage 74.41% 74.35% -0.06%
==========================================
Files 346 346
Lines 110798 110797 -1
==========================================
- Hits 82451 82387 -64
- Misses 28347 28410 +63
☔ View full report in Codecov by Sentry. |
| @@ -1135,7 +1135,7 @@ function trace_lattice_with_isometry_and_transfer_data(H::AbstractLat{T}; alpha: | |||
| return H, f, AbstractSpaceRes(V, V, identity_matrix(E, n), identity_matrix(E, n)) | |||
| end | |||
|
|
|||
| @req (degree(E) == 2) && (is_totally_complex(E)) && (is_totally_real(base_field(E))) "The base field of H must be CM" | |||
There was a problem hiding this comment.
I think this still holds, even in the infinite order case.
There was a problem hiding this comment.
In the example of the issue it does not hold, E is real. It does not seem to be actually required to have E/K CM.
There was a problem hiding this comment.
You are right of course.
simonbrandhorst
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #1210 .