Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow Hecke.test_module("bla", false) again #1186

Merged
merged 3 commits into from
Aug 10, 2023
Merged

allow Hecke.test_module("bla", false) again #1186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa37983
allow Hecke.test_module("bla", false) again
fieker Aug 10, 2023
a1739f9
more robust - to also allow global test
fieker Aug 10, 2023
d1e5316
try again...
fieker Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Hecke.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,8 +462,8 @@
Hecke.@eval _with_polymake = $with_polymake
assertions(true)
@info("Running tests for $x in same session")
include(setup_file)
include(test_file)
Base.include(Main, setup_file)
Base.include(Main, test_file)

Check warning on line 466 in src/Hecke.jl

View check run for this annotation

Codecov / codecov/patch

src/Hecke.jl#L465-L466 

Added lines #L465 - L466 were not covered by tests
assertions(false)
end
end
Expand Down
9 changes: 6 additions & 3 deletions test/setup.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ end

Hecke.assertions(true)

if long_test
if (isdefined(Hecke, :long_test) && Hecke.long_test) ||
(isdefined(Main, :long_test) && Main.long_test)
macro long_test(ex)
ex
end
Expand All @@ -33,7 +34,8 @@ else
end
end

if _with_gap
if (isdefined(Hecke, :_with_gap) && Hecke._with_gap) ||
(isdefined(Main, :_with_gap) && Main._with_gap)
macro with_gap(ex)
ex
end
Expand All @@ -43,7 +45,8 @@ else
end
end

if _with_polymake
if (isdefined(Hecke, :_with_polymake) && Hecke._with_polymake) ||
(isdefined(Main, :_with_polymake) && Main._with_polymake)
macro with_polymake(ex)
ex
end
Expand Down
Loading