more

thofma · Nov 15, 2024 · 4eb68b8 · 4eb68b8
1 parent 3a41198
commit 4eb68b8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/NumFieldOrd/NfOrd/Ideal/Ideal.jl b/src/NumFieldOrd/NfOrd/Ideal/Ideal.jl
@@ -1033,6 +1033,9 @@ function _minmod(a::ZZRingElem, b::AbsNumFieldOrderElem)
 end
 
 function _minmod_easy(a::ZZRingElem, b::AbsSimpleNumFieldOrderElem)
+  if is_one(a)
+    return a
+  end
   Zk = parent(b)
   k = number_field(Zk)
   if fits(Int, a)
@@ -1150,7 +1153,6 @@ end
 
 
 function _minmod_comp(a::ZZRingElem, b::AbsSimpleNumFieldOrderElem)
-
   Zk = parent(b)
   k = number_field(Zk)
   acom, auncom = ppio(a, index(Zk))

diff --git a/src/NumFieldOrd/NfOrd/MaxOrd/Polygons.jl b/src/NumFieldOrd/NfOrd/MaxOrd/Polygons.jl
@@ -741,7 +741,6 @@ function _decomposition(O::AbsNumFieldOrder, I::AbsNumFieldOrderIdeal, Ip::AbsNu
           Ba = basis(P, copy = false)
           for i in 1:degree(O)
             if !is_norm_divisible_pp((v*Ba[i] + u).elem_in_nf, modulo)
-              @assert !is_zero(mod(ZZ(norm((v*Ba[i] + u).elem_in_nf)), modulo))
               u = v*Ba[i] + u
               break
             end