Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for anaconda 5.1.0 and 5.2.0 (Closes #30) #31

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Support for anaconda 5.1.0 and 5.2.0 (Closes #30) #31

wants to merge 5 commits into from

Conversation

ppoilbarbe
Copy link

@ppoilbarbe ppoilbarbe commented Aug 24, 2018

  • Added support for anaconda 5.1.0 and 5.2.0 (I needed only 5.2.0)
  • Corrected little bug when showing license file. Entering just one space is not enough since there is more than one page (depending on license file length and terminal size). In fact completely removed input file for installer, using options. This don't show license file and is more accurate.
  • Lowered requirement for chef from 13 to 12 (there is not 13 specificity and it runs perfectly on chef client 12)
  • Modified installation no do nothing at all if licence file is not accepted (no download, no directory creation).
  • Used marker file for idempotent operation. Checking if directory exists may make anaconda not installed if an error occurs during previous installation try.

Related to issue #30 that I opened.

@thmttch
Copy link
Owner

thmttch commented Aug 31, 2018

Hey @ppoilbarbe, thanks for the PR, and PR notes! I'll try and take a look at it this weekend. At a glance it looks pretty good, except for the Chef 13 -> 12 change; I'm a little hesitant about that, and will need to look into it more.

@ppoilbarbe
Copy link
Author

Hello,
In my society we did not switch to Chef client 13.
I tried every functions of recipes and had a look at code. I did not find any specificity.
Maybe did I miss something, it is up to you to tell me.
If 13 is needed, I will make another commit to revert back to 13.
Thanks.

recipes/default.rb Outdated Show resolved Hide resolved
recipes/default.rb Outdated Show resolved Hide resolved
recipes/default.rb Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants