Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to uv and ruff #2

Merged
merged 14 commits into from
Sep 2, 2024
Merged

Upgrade to uv and ruff #2

merged 14 commits into from
Sep 2, 2024

Conversation

tm-danna-ang
Copy link
Collaborator

What does this PR do?

  • Upgrades the package manager to uv and code linter and formatter to ruff for faster setup and code review
  • Uses pyproject.toml instead of requirements.in for listing dependencies
  • Uses a forked version of dl4ds as the original repo has a scikit-learn installation bug
  • Applies Ruff rules and formatting to existing notebooks

Where should the reviewers start?

  • pyproject.toml for the dependencies
  • Automatic Ruff fixes and formatting have been applied to the notebooks with the exception of the following manual edits:
    • Rule E712 Avoid equality comparisons to True; use if OVERWRITE_SECRETS: for truth checks
      • notebooks/00-download-data/download_era5.ipynb:cell 5:1:42
    • Rule E722 Do not use bare "except"
      • notebooks/00-download-data/download_ndvi.ipynb:cell 18:31:5
      • notebooks/00-download-data/fix_downloads/convert_era5_grib_to_netcdf.ipynb:cell 8:6:5
      • notebooks/00-download-data/fix_downloads/convert_era5_grib_to_netcdf.ipynb:cell 14:61:13
      • notebooks/01-align-grids/03_interpolate_data.ipynb:cell 12:23:5
      • notebooks/01-align-grids/03_interpolate_data.ipynb:cell 13:23:5

This PR can be merged after #1 .

@tm-jace-peralta tm-jace-peralta merged commit 101b0bc into master Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants