Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exponential backoff retry logic on initial connection #581

Closed
wants to merge 3 commits into from

Conversation

aarro
Copy link

@aarro aarro commented Jul 13, 2024

Context

My environment lags a bit at getting a container connected to the internet. As a result, the check for connectivity to steam and install/update would fail. I've added an exponential_backoff function that will retry 5 times and applied it to the first connection check.

Choices

Seemed like the best solution.

Test instructions

I published it to dockerhub and installed pulled it into my environment with the lagging network. I then observed the now successful logs.

going to upload logs when I can again

Checklist before requesting a review

  • I have performed a self-review/test of my code
  • n/a I've added documentation about this change to the docs.
  • I've not introduced breaking changes.
  • My changes do not violate linting rules.

@aarro
Copy link
Author

aarro commented Jul 13, 2024

Note: I'm using the prettier vs code extension (link) and it formatted the files I edited. It fixed some conflicting styles but also caused more than a few line changes. If preferred, I can remove those style changes and resubmit.

@thijsvanloef
Copy link
Owner

@aarro Don't mind the style changes, but I believe that these are best to open a seperate PR for, keeps the purpose of this PR more clear.

@thijsvanloef thijsvanloef added the stale Issue/PR has had no activity label Aug 6, 2024
@thijsvanloef
Copy link
Owner

Is this still being worked on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue/PR has had no activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants