Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shellcheckrc #418

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Add shellcheckrc #418

merged 3 commits into from
Feb 21, 2024

Conversation

Dashboy1998
Copy link
Contributor

@Dashboy1998 Dashboy1998 commented Feb 20, 2024 •
edited
Loading

Context

  • For all bash scripts which use source we must tell the linter to ignore it with # shellcheck source=/dev/null

Choices

  • Added .shellcheckrc so we properly tell the linter the source of the file per SC1091

Test instructions

N/A

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@Dashboy1998 Dashboy1998 marked this pull request as ready for review February 20, 2024 19:04
@thijsvanloef thijsvanloef merged commit 7020f73 into thijsvanloef:main Feb 21, 2024
11 checks passed
MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
@thijsvanloef
Merge pull request thijsvanloef#418 from Dashboy1998/shell-lint-config
fba8659 
Add shellcheckrc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dashboy1998 @thijsvanloef