Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix always showing: "Game not at target version" #409

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

thijsvanloef
Copy link
Owner

Context

With the recent addition of the option to pin the manifest this small bug made its way into the logs.
This change makes sure that the message only appears when needed

Choices

Added a check to make sure that the manifest is set before checking if it matches the current version

Test instructions

  1. Do not set TARGET_MANIFEST_ID
  2. start the server
  3. notice that it only displays the message when applicable

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@thijsvanloef thijsvanloef added the bug Something isn't working label Feb 19, 2024
@thijsvanloef
Copy link
Owner Author

@Phelms215 found a small bug :)

@thijsvanloef thijsvanloef merged commit e72c43d into main Feb 19, 2024
9 checks passed
@thijsvanloef thijsvanloef deleted the fix-game-not-target branch February 19, 2024 20:08
MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
…rget

Fix always showing: "Game not at target version"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant