-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add unit test #351
add unit test #351
Conversation
docker/setup-qemu-action adds a layer of emulation that enables Docker to run ARM64 images among others. With that in the workflow, it should be able to run a test for the ARM64 images as well, albeit not an actual macOS environment. Also on that note, you won't need the QEMU step in the workflow for AMD64 images as the |
Thx for your suggest, but when I try to install Docker on macOS, it installs a VM with ubuntu-23.10-minimal-cloudimg-amd64. Is this also acceptable?
Log:
|
You probably shouldn't be using the You'd want to still use
|
Thank you so much! |
One thing I'll suggest is turning each unit test into its own reusable worklfow or action https://docs.github.com/en/actions/using-workflows/reusing-workflows It'll allow future us to run unit tests remotely in other workflows, which right now isn't all that beneficial but in the future it might be Only a suggestion, not a reccomendation or requirement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great! And I can't wait until more tests are added this way
add unit test
Context
uni-test.yml
netcat
command../palworld/backups/
path contains a backup folder.Due to the limitation that macOS environments in GitHub Actions do not support Docker forARM64
, it cannot be included.Refer to: https://github.com/orgs/community/discussions/25777#discussioncomment-3249229Not sure how to check If PalWorldSettings.ini is valid.
Choices
Test instructions
Checklist before requesting a review