-
-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to generate a WorldOption.sav file automatically #337
Add an option to generate a WorldOption.sav file automatically #337
Conversation
Please also test this with existing savedata. |
Co-authored-by: Carlos Martinez <[email protected]>
Opt out of HTTP POST request and use Python tools
I've removed the previous script of using the online API and opted to use the Python tools instead. I modified a portion of the palworld-worldoptions script to generate a JSON file for the palworld-save-tools to be usable instead of uesave-rs to remove the extra build step for arm64 images. Tested it with both new and existing savedata and everything works as expected. |
Closing in favor of #380 |
Context
WorldOption.sav
file is usually generated from a single player save and not a dedicated server. However, a dedicated server can still recognize the .sav file.BaseCampWorkerMaxNum
being locked at 15. Having an option to generate aWorldOption.sav
file would allow these settings to be modified.WorldOption.sav
files from this website. While this works, it would negate the purpose of having the settings as env vars in a Docker container as having theWorldOption.sav
file would ignore thePalWorldSettings.ini
file generated from those env vars. (Enable PVP or Set `BaseCampWorkerMaxNum` to 20 on a dedicated Server #293)Choices
The way it works is a simple HTTP POST request with the compiled settings as its body to that same website which generates the .sav file and saved to the appropriate folder within the container. Another option is to have the tool itself within the Docker image but that would require us having Python running inside the container.PalWorldSettings.ini
file to be processed by palworld-save-tools and generate the actualWorldOption.sav
file.WorldOption.sav
file and generate a new one every boot to make sure it follows the current values of the Docker env vars.PalWorldSettings.ini
is used instead.POST requestfile generation fails, GENERATE_WORLD_OPTION is ignored and will revert back to usingPalWorldSettings.ini
.Test instructions
Checklist before requesting a review