-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pause without players #273
Conversation
As an alternative to using SIGSTOP you could shutdown the server, monitor the port then start the server. |
I think if I stop the server binary, I also stop the container because start.sh will exit. |
As written yes. With a few modifications to start.sh you could change that behavioral. |
Do you think it would make sense to make the pal server into a service so we can start/restart/stop it easier? If that's even possible inside the container. Aside from that. I am not sure if a restart would be fast enough to connect again without timeout |
I'm not sure how running as a service would make a difference. You're probably right, the time to start the server might be too long. However SIGSTOP would cause issues with autoreboot.sh, backup.sh, and update.sh. Those don't check if the rcon command was successful, they assume it was. The term handler in init.sh would produce an error for rcon too and it would hang as the server would never stop since the rcon stop would never be recieved by the paused server. While it would prevent restore.sh from working properly, that wouldn't have an big issues as @seoseonyu did a great job with error handlers. That isn't to say this isn't doable. It definitely is doable but it would be a big PR. I would say something making that many changes should be multiple PRs due to the error handling, rcon checking, and status checking we would need to add to autoreboot.sh, backup.sh, and update.sh. |
closing this. I think it is better for an external Script to pause the container instead of trying to stuff this in (at least at the moment). Maybe the game will give us a command in a later version. |
Context
Choices
Feedback is appreciated, if you see something that can be improved!
Todo
Test instructions
Manually
docker exec palworld-server pause
echo>/dev/udp/127.0.0.1/8211
or start the game and loginCron
Checklist before requesting a review