Update: Enhanced compilation scripts #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix `wget --progress=dot:giga`
fix file not found when using darwin
|
Why remove checksum validation? |
It's hard-coded in the script and only the amd64 binaries are validated, and I'm constantly updating this PR so that multiple binaries across platforms can be checked. |
fix sha1sum for supercronic, but checksum still mssing.
|
COME ON. The ARM platform is irrelevant, because of the BTW, container with AMD64 is running normally in macOS Silicon, yes rosetta2. ALL DONE. PLZ check. |
thijsvanloef
changed the title
|
Made some revision:
|
gotcha, thanks. btw, conflicts resolved. |
MusclePr
pushed a commit
to MusclePr/palworld-server-docker
that referenced
this pull request
Jun 19, 2024
Update: Enhanced compilation scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1: Add a build-time architecture parameters below:ARGsDefaultAvailableARCHamd64amd64, arm64OSlinuxlinux, darwinIf we need to build a macOS Silicon image should be thoughdocker build --build-arg ARCH=arm64 --build-arg OS=darwin -t user/image:tag ..2: Add priority to determine whether the current architecture is supported, and exit after an exception.3: Controllable
SUPERCRONICandRCONversion numbers.4: Remove the
-qparameter ofwget, instead ofwget --progress=dot:giga, which is especially important for the visualization of logs during the compilation process.5: Unified, highly readable code and comments.
6: Add
md5sumforRCON.