fix: swap image.name to image.repository #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Filipe-Souza should I run helm-docs manually? |
thijsvanloef
added
kubernetes
|
@anthr76 Is this PR ready to merge? |
|
@anthr76 I personally use git pre-commit hooks to update the docs, running manually is fine also. |
Signed-off-by: Anthony Rabbito <[email protected]>
|
Sounds good! In that case this is ready to merge. |
Signed-off-by: Anthony Rabbito <[email protected]>
MusclePr
pushed a commit
to MusclePr/palworld-server-docker
that referenced
this pull request
Jun 19, 2024
fix: swap image.name to image.repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Swapping
image.nametoimage.repositorywhich tends to be more widely used in popular helm charts. This also has the added benefit of allowing it to work with the renovatebotChoices
To be more in-line with popular helm charts and allow the renovatebot to manage dependencies.
Test instructions
Installing the helm chart
I'm not sure if automation will update the values markdown?
Checklist before requesting a review