-
-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- Update the way env variables are managed #201
- Update the way env variables are managed #201
Conversation
- Now a env-file is present to make setup more clean to execute; - Added the grace period to the docker run command; - Updated the docs to reflect this new suggestions;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I agree that this makes it a lot easier, my thought process is that the majority does not clone this entire repo but instead just pulls the image from docker hub.
I would like to include the .env.example in the repo, but not change the docker-compose.yml examples. But instead create a disclaimer in the "How to deploy - Docker Compose" heading saying that this can also be managed using an .env file
Makes sense, I'm going to update the PR |
… file; - Reverted docker-compose.yml to the original service;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thank you!
…iles - Update the way env variables are managed
Context
Choices
Test instructions
Checklist before requesting a review