updating STARTCOMMAND to array with += syntax and allowing spaces in …

[clarkent86]

Updating to using array for STARTCOMMAND due to issues that su steam -c "${STARTCOMMAND}" can have with escaped quotes and spaces, also this will allow for spaces in server names and passwords

Context

Allow users to use spaces in certain environment variables

Choices

• Better handling of spaces in program arguments that should allow them, such as server name and passwords

Test instructions

1. Run the server with this change and have spaces in the passwords or in the server name

Checklist before requesting a review

• I have performed a self-review of my code
• I've added documentation about this change to the README.
  there is no mention spaces aren't supported, so this will just be helpful overall
• I've not introduced breaking changes.

[fryfrog]

Brilliant!

[thijsvanloef]

@clarkent86 Thank you for creating this PR, however I did find an issue. Changing this to an array while not changing the way the startcommand gets expanded, does not work.
As shellcheck gives the following error on su steam -c "${STARTCOMMAND}":

Expanding an array without an index only gives the first element.shellcheckSC2128

Which I could confirm when running it myself:

palworld-server  | *****CHECKING FOR EXISTING CONFIG*****
palworld-server  | RCON_ENABLED=true
palworld-server  | RCON_PORT=25575
palworld-server  | ./PalServer.sh
palworld-server  | Shutdown handler: initalize.
palworld-server  | Increasing per-process limit of core file size to infinity.
palworld-server  | [S_API] SteamAPI_Init(): Loaded local 'steamclient.so' OK.
palworld-server  | CAppInfoCacheReadFromDiskThread took 1 milliseconds to initialize
palworld-server  | Setting breakpad minidump AppID = 2394010
palworld-server  | [S_API FAIL] Tried to access Steam interface SteamUser021 before SteamAPI_Init succeeded.
palworld-server  | [S_API FAIL] Tried to access Steam interface SteamFriends017 before SteamAPI_Init succeeded.
palworld-server  | [S_API FAIL] Tried to access Steam interface STEAMAPPS_INTERFACE_VERSION008 before SteamAPI_Init succeeded.
palworld-server  | [S_API FAIL] Tried to access Steam interface SteamNetworkingUtils004 before SteamAPI_Init succeeded.

Only ./PalServer.sh gets called with no parameters

[clarkent86]

@clarkent86 Thank you for creating this PR, however I did find an issue. Changing this to an array while not changing the way the startcommand gets expanded, does not work. As shellcheck gives the following error on su steam -c "${STARTCOMMAND}":

Expanding an array without an index only gives the first element.shellcheckSC2128

Which I could confirm when running it myself:

palworld-server  | *****CHECKING FOR EXISTING CONFIG*****
palworld-server  | RCON_ENABLED=true
palworld-server  | RCON_PORT=25575
palworld-server  | ./PalServer.sh
palworld-server  | Shutdown handler: initalize.
palworld-server  | Increasing per-process limit of core file size to infinity.
palworld-server  | [S_API] SteamAPI_Init(): Loaded local 'steamclient.so' OK.
palworld-server  | CAppInfoCacheReadFromDiskThread took 1 milliseconds to initialize
palworld-server  | Setting breakpad minidump AppID = 2394010
palworld-server  | [S_API FAIL] Tried to access Steam interface SteamUser021 before SteamAPI_Init succeeded.
palworld-server  | [S_API FAIL] Tried to access Steam interface SteamFriends017 before SteamAPI_Init succeeded.
palworld-server  | [S_API FAIL] Tried to access Steam interface STEAMAPPS_INTERFACE_VERSION008 before SteamAPI_Init succeeded.
palworld-server  | [S_API FAIL] Tried to access Steam interface SteamNetworkingUtils004 before SteamAPI_Init succeeded.

Only ./PalServer.sh gets called with no parameters

@thijsvanloef Apologies! I was testing with a local script and forgot to expand the array correctly when applying it to this code base. I should've noticed with the other comment!

Should be fixed now, can you try again?

[clarkent86]

@Dashboy1998 thanks! It looks like I missed the echo command as well, updated. Also, expanding with the @ instead of the * preserves the spaces as we want for the command.

[thijsvanloef]

@clarkent86 Awesome work, ready to merge :)

[thijsvanloef]

Needed to revert the changes, I've done some more testing and it seems like it won't start:

palworld-server  | Connecting anonymously to Steam Public...OK
palworld-server  | Waiting for client config...OK
palworld-server  | Waiting for user info...OK
palworld-server  |  Update state (0x3) reconfiguring, progress: 0.00 (0 / 0)
palworld-server  |  Update state (0x5) verifying install, progress: 3.45 (77589729 / 2248053389)
palworld-server  |  Update state (0x5) verifying install, progress: 16.11 (362079510 / 2248053389)
palworld-server  |  Update state (0x5) verifying install, progress: 34.05 (765465170 / 2248053389)
palworld-server  |  Update state (0x5) verifying install, progress: 51.43 (1156196222 / 2248053389)
palworld-server  |  Update state (0x5) verifying install, progress: 69.41 (1560371980 / 2248053389)
palworld-server  |  Update state (0x5) verifying install, progress: 88.65 (1993011775 / 2248053389)
palworld-server  | Success! App '2394010' fully installed.
palworld-server  | *****CHECKING FOR EXISTING CONFIG*****
palworld-server  | RCON_ENABLED=true
palworld-server  | RCON_PORT=25575
palworld-server  | *****STARTING SERVER*****
palworld-server  | ./PalServer.sh -port=8211 -players=16 -servername="WorldofPals" -serverpassword="worldofpals" -adminpassword="adminPasswordHere" -queryport=27015 -useperfthreads -NoAsyncLoadingThread -UseMultithreadForDS
palworld-server  | su: invalid option -- 'o'
palworld-server  | Try 'su --help' for more information.

[thijsvanloef]

@clarkent86 ☝️

[clarkent86]

Got it. Seems like there's something unexpected happening, I'll need to figure out how to source a custom image on my NAS. Sorry about that.

[thijsvanloef]

@clarkent86 No worries, shit happens, nothing was deployed 🙂

[clarkent86]

Got it working and fully tested now instead of just printing the startcmd in a script, PR incoming!