Skip to content

Commit

Permalink
Replace :latest uses with the true-latest version
Browse files Browse the repository at this point in the history
# Motivations
To prevent breaking-changes leaking into our suggested docker-compose and more importantly our helm-chart, we should be using the latest supported version of the docker image, not latest

# Modifications
- Replace `:latest`: with the true-latest supported version, `0.24.1`, in our example docker-compose, helm-chart, and k8s example
  • Loading branch information
Twinki14 committed Feb 7, 2024
1 parent c7aff01 commit 6ee131a
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 6 deletions.
5 changes: 2 additions & 3 deletions charts/palworld/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
---
apiVersion: v2
name: palworld
version: 0.1.0
version: 0.24.1
description: This chart will provide a Palworld server installation on a kubernetes cluster
type: application
keywords:
Expand Down Expand Up @@ -31,7 +30,7 @@ annotations:
url: https://github.com/thijsvanloef/palworld-server-docker
artifacthub.io/images: |
- name: palworld-server-docker
image: thijsvanloef/palworld-server-docker:latest
image: thijsvanloef/palworld-server-docker:0.24.1
artifacthub.io/screenshots: |
- title: PalWorld
url: https://cdn.akamai.steamstatic.com/steam/apps/1623730/header.jpg
2 changes: 1 addition & 1 deletion charts/palworld/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ server:
# -- Repository of the image, without the tag.
repository: thijsvanloef/palworld-server-docker
# -- The tag of the image.
tag: latest
tag: 0.24.1
# -- Define the pull policy for the server image.
imagePullPolicy: IfNotPresent

Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
services:
palworld:
image: thijsvanloef/palworld-server-docker:latest
image: thijsvanloef/palworld-server-docker:0.24.1
restart: unless-stopped
container_name: palworld-server
stop_grace_period: 30s # Set to however long you are willing to wait for the container to gracefully stop
Expand Down
2 changes: 1 addition & 1 deletion k8s/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
spec:
containers:
- name: palworld-server
image: thijsvanloef/palworld-server-docker
image: thijsvanloef/palworld-server-docker:0.24.1
imagePullPolicy: IfNotPresent
ports:
- containerPort: 8211
Expand Down

0 comments on commit 6ee131a

Please sign in to comment.