Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

honor settings in ::libvirt #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

honor settings in ::libvirt #63

wants to merge 1 commit into from

Conversation

cbergmann
Copy link

If ::libvirt overwrites this setting it is ignored.

@cbergmann
honor settings in ::libvirt
1d76435 
If ::libvirt overwrites this setting it is ignored.
petems added a commit to petems/puppet-libvirt that referenced this pull request Jul 10, 2017
@petems
Creating petems-libvirt fork
0e777e5 
Merging these PR's that fix issues for me:
* thias#64
* thias#52
* thias#63
* Moves tests/ to examples/
* Changes meta-data to my fork petems-libvirt
* Eventually use the Vox Pupuli fork:
  * thias#74
@rodrigomgm
Copy link

libvirt-bin package was dropped in 18.10, now it is libvirt-daemon-system and libvirt-clients, could you please merge this request? also service name is no longer libvirt-bin, but libvirtd.
Overriding it via hiera is pointless because of this dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbergmann @rodrigomgm