Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor small annoyances with current code #6

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Conversation

thiagomajesk
Copy link
Owner

@thiagomajesk thiagomajesk commented Mar 22, 2023

  • Moves Swish.Dialog.Transitions to /dialog (following the same pattern as in Add toasts API #3)
  • Removes hidden trailing whitespace from docs that prevented correct formatting
  • Passes attrs directly to Dialog.new function (following the same pattern as in Add toasts API #3)
  • Fixes Dialog not accepting custom ids
  • Introduces Swish.EL module with some useful helpers that allows:
    • Unifying element id template generation (always positive and not necessarily increasing)
    • Automatically extracting and scaping id from components that can have an id

@thiagomajesk thiagomajesk merged commit 9220e3f into master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants