-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split up Server into Renderer/API for Staging #9827
Conversation
API server is still using Webbrick for some reason (maybe puma has to be in the gem file and not just installed by doing |
mh.. Ok I did a little bit of testing and it looks like we do need sessions because we use sessions in APIs all the time to check for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per discussion in Slack call
As far as I can see, this PR does nothing to set |
no. We are still setting web concurrency here |
The next PR will be the "set everything to 1 cpu and disable web concurrency PR". It's also important to say that this is staging only so we can run the load test with this setup |
Ah, okay. So instead of setting the env variable to If you have this on your radar as a follow-up, then that's totally fine by me. |
Recreated so I can deploy from it