Edit Profile Form #9811
Merged
Edit Profile Form #9811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljames-dj
force-pushed
the
edit-profile-form
branch
2 times, most recently
from
47d7e5d to
317ca23
Compare
kr-matthews
reviewed
Aug 24, 2024
app/webpacker/components/ContactEditProfilePage/EditProfileFormWithWcaId.jsx
Outdated
Show resolved
Hide resolved
danieljames-dj
force-pushed
the
edit-profile-form
branch
from
6dac4bd to
9bc5dc8
Compare
|
@thewca-bot deploy staging |
|
(If anyone is wondering why I tried to trigger the deployment, Daniel allowed me to try to check if everyone has access to trigger it) |
gregorbg
requested changes
Oct 30, 2024
app/webpacker/components/ContactEditProfilePage/EditProfileForm.jsx
Outdated
Show resolved
Hide resolved
app/webpacker/components/ContactEditProfilePage/EditProfileForm.jsx
Outdated
Show resolved
Hide resolved
app/webpacker/components/ContactEditProfilePage/EditProfileForm.jsx
Outdated
Show resolved
Hide resolved
danieljames-dj
force-pushed
the
edit-profile-form
branch
2 times, most recently
from
f7acc4a to
e3ebff2
Compare
danieljames-dj
force-pushed
the
edit-profile-form
branch
from
e3ebff2 to
dbb712e
Compare
danieljames-dj
force-pushed
the
edit-profile-form
branch
from
dbb712e to
ece3aa4
Compare
danieljames-dj
force-pushed
the
edit-profile-form
branch
from
ece3aa4 to
18bf284
Compare
gregorbg
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the edit profile form is merged along with the main contact form, but this is making the main contact form increasingly complex. This PR is an attempt to make 'edit profile' portion of the form into it's own separate form.
Temporarily, this particular form is not linked anywhere else in website, this can be accessed only if people know the URL. Once this is merged, I'll raise another PR to remove everything related to 'edit profile' from main contact form and instead if the user selects 'edit profile', then will give the user the button to redirect to 'edit profile form' page.EDIT: This is now linked with the main contact form.