Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth Login for Staging #9712

Merged
merged 23 commits into from
Aug 8, 2024
Merged

OAuth Login for Staging #9712

merged 23 commits into from
Aug 8, 2024
+157 −40

Conversation

dunkOnIT
Copy link
Contributor

@dunkOnIT dunkOnIT commented Jul 30, 2024 •
edited by FinnIckler
Loading

No description provided.

@FinnIckler FinnIckler changed the title Auto-login for live load testing OAuth Login for Staging Jul 30, 2024
@FinnIckler
Copy link
Member

took over this PR to implement OAuth login instead

@FinnIckler FinnIckler marked this pull request as ready for review July 30, 2024 15:08
@FinnIckler
Copy link
Member

@thewca-bot deploy staging

@FinnIckler
Copy link
Member

@thewca-bot deploy staging

1 similar comment
@dunkOnIT
Copy link
Contributor Author

@thewca-bot deploy staging

gregorbg
gregorbg requested changes Jul 31, 2024
View reviewed changes
env_config.rb Outdated Show resolved Hide resolved
app_secrets.rb Outdated Show resolved Hide resolved
app/views/devise/sessions/new.html.erb Outdated Show resolved Hide resolved
app/controllers/sessions_controller.rb Outdated Show resolved Hide resolved
@FinnIckler
Copy link
Member

image
This is the watermark I just added. Other suggestions welcome

gregorbg
gregorbg reviewed Aug 2, 2024
View reviewed changes
app/controllers/sessions_controller.rb Outdated Show resolved Hide resolved
app/controllers/sessions_controller.rb Outdated Show resolved Hide resolved
app/views/devise/sessions/new.html.erb Show resolved Hide resolved
gregorbg
gregorbg approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@gregorbg gregorbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs a merge conflict resolution.

Did you reach a consensus on the watermark? I am generally in favor of it.

@dunkOnIT dunkOnIT merged commit 22a53dd into thewca:main Aug 8, 2024
1 check passed
@dunkOnIT dunkOnIT deleted the test/load-test-setup branch August 8, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FinnIckler FinnIckler FinnIckler left review comments

@gregorbg gregorbg gregorbg approved these changes

Assignees

@dunkOnIT dunkOnIT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dunkOnIT @FinnIckler @gregorbg