Reuse import logic from v1 #9704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FinnIckler
force-pushed
the
v2/import-reuse
branch
from
18c91be to
ef14723
Compare
|
thewca/wca-registration#627 for the wca-registration side |
|
Also, am I seeing this correctly that the Status field that's in the csv export actually doesn't matter? It looks to me that we just say that if the name is in the csv than it's accepted and if it isn't (but it was before) it's deleted. |
|
Just curious, I think with V3 this PR is completely redundant? |
|
yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not Tested yet, mostly looking for an opinion on if this is good. Will also have to change the export logic to use this format. I don't think it is worth introducing a new format and writing new checks until we allow 3rd parties to just use our API and remove the csv import