Allow qualification on the day of the deadline #9412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunkOnIT
previously approved these changes
May 24, 2024
|
@gregorbg we may want to add test cases for |
gregorbg
force-pushed
the
fixup/qualifying-on-or-before
branch
from
5ffd04f to
d621d39
Compare
dunkOnIT
approved these changes
Dec 5, 2024
|
Isn't this V1? |
|
I believe v2 is just calling the qualification class to check qualifications, so it should still apply |
|
Can you also update the text on https://www.worldcubeassociation.org/competitions/WC2025#competition-events ? Under "Qualification" it says "by DATE_MINUS_ONE", and at the bottom it says "before". Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per WRT remark. This PR merely swaps a
<comparison for a<=comparison