Prevent cancelled user from registering if registration is closed #10379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FinnIckler
reviewed
Dec 7, 2024
|
Nope. This will still not show the registration component when a registration is cancelled, but the registration period is still open. The correct solution is to migrate the Registration Closed message to react and then check if the registration is closed and the user is not registered or cancelled and then render that. I can do that on Monday if that is fine |
|
If you want to do it this weekend we can just merge only the backend and just show the cancelled people the error until monday |
|
Ah yep of course, very silly. No urgency on this as I think they're all sorted for Worlds now, but removed the frontend change so you can either add it to this PR/raise it in a new one |
gregorbg
approved these changes
Dec 9, 2024
gregorbg
requested changes
Dec 10, 2024
gregorbg
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tim has been struggling with this issue when they close World's reg, and I realized that the problem is that users with cancelled registrations shouldn't be able to register after reg is closed - but our system views them as having a registration, so we still render the Register panel and accept the "update".