Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI to update ticket status in the ticket header #10377

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions app/webpacker/components/Tickets/TicketHeader.jsx

This file was deleted.

88 changes: 88 additions & 0 deletions app/webpacker/components/Tickets/TicketHeader/StatusView.jsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
import React, { useState } from 'react';
import { Button, Dropdown, Icon } from 'semantic-ui-react';
import _ from 'lodash';
import { actionUrls } from '../../../lib/requests/routes.js.erb';
import { ticketStatuses } from '../../../lib/wca-data.js.erb';
import useSaveAction from '../../../lib/hooks/useSaveAction';
import Loading from '../../Requests/Loading';
import useInputState from '../../../lib/hooks/useInputState';

const ticketTypePrefix = 'Tickets';

function StatusViewEditMode({
ticketDetails, currentStakeholder, setEditMode, sync,
}) {
// metadataType will be a string like TicketsTicketType
const { ticket: { id, metadata, metadata_type: metadataType } } = ticketDetails;
// To get ticketType, first remove prefix 'Tickets' and then convert it to snake case.
const ticketType = _.snakeCase(_.replace(metadataType, ticketTypePrefix, ''));

const [newStatus, setNewStatus] = useInputState(metadata.status);
const { save, saving } = useSaveAction();

function saveStatus(status) {
save(
actionUrls.tickets.updateStatus(id),
{
ticket_status: status,
acting_stakeholder_id: currentStakeholder.id,
},
sync,
{ method: 'POST' },
);
}

if (saving) {
return <Loading />;
}

return (
<>
<span>{'Status: '}</span>
<Dropdown
inline
options={Object.keys(ticketStatuses[ticketType]).map((key) => ({
key,
text: ticketStatuses[ticketType][key],
value: key,
}))}
Comment on lines +44 to +48
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of computing these inline. Move to a separate useMemo please 🙃

value={newStatus}
onChange={setNewStatus}
/>
{' '}
<Button
primary
disabled={newStatus === metadata.status}
onClick={() => saveStatus(newStatus)}
>
Save
</Button>
{' '}
<Button onClick={() => setEditMode(false)}>Cancel</Button>
</>
);
}

export default function StatusView({ ticketDetails, currentStakeholder, sync }) {
const { ticket: { metadata } } = ticketDetails;
const [editMode, setEditMode] = useState(false);

return editMode ? (
<StatusViewEditMode
ticketDetails={ticketDetails}
currentStakeholder={currentStakeholder}
setEditMode={setEditMode}
sync={sync}
/>
) : (
<>
<span>{`Status: ${metadata.status}`}</span>
{' '}
<Icon
name="edit"
link
onClick={() => setEditMode(true)}
/>
</>
);
}
20 changes: 20 additions & 0 deletions app/webpacker/components/Tickets/TicketHeader/index.jsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import React from 'react';
import { Card, Header } from 'semantic-ui-react';
import StatusView from './StatusView';

export default function TicketHeader({ ticketDetails, currentStakeholder, sync }) {
const { ticket: { id } } = ticketDetails;

return (
<Card fluid>
<Card.Content>
<Header as="h1">{`Ticket #${id}`}</Header>
<StatusView
ticketDetails={ticketDetails}
currentStakeholder={currentStakeholder}
sync={sync}
/>
</Card.Content>
</Card>
);
}
8 changes: 6 additions & 2 deletions app/webpacker/components/Tickets/index.jsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useMemo, useState } from 'react';
import React, { useMemo } from 'react';
import {
Button, Container, Dropdown, Message, Modal,
} from 'semantic-ui-react';
Expand Down Expand Up @@ -41,7 +41,11 @@ function SkateholderSelector({ stakeholderList, setUserSelectedStakeholder }) {
function TicketContent({ ticketDetails, currentStakeholder, sync }) {
return (
<>
<TicketHeader ticketDetails={ticketDetails} />
<TicketHeader
ticketDetails={ticketDetails}
currentStakeholder={currentStakeholder}
sync={sync}
/>
<TicketWorkbench
ticketDetails={ticketDetails}
sync={sync}
Expand Down
Loading