Migrate the My Competition Table to React #10370
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kr-matthews
reviewed
Dec 5, 2024
app/webpacker/components/MyCompetitions/UpcomingCompetitionTable.jsx
Outdated
Show resolved
Hide resolved
app/webpacker/components/MyCompetitions/UpcomingCompetitionTable.jsx
Outdated
Show resolved
Hide resolved
app/webpacker/components/MyCompetitions/UpcomingCompetitionTable.jsx
Outdated
Show resolved
Hide resolved
FinnIckler
force-pushed
the
react/my-competitions-again
branch
from
cc378c8 to
6b075a5
Compare
|
Admin User: |
|
tests fail because of .erb tests. Should I just remove these? @gregorbg |
FinnIckler
commented
Dec 6, 2024
kr-matthews
reviewed
Dec 7, 2024
app/webpacker/components/MyCompetitions/PastCompetitionTable.jsx
Outdated
Show resolved
Hide resolved
gregorbg
reviewed
Dec 9, 2024
gregorbg
requested changes
Dec 16, 2024
app/webpacker/components/MyCompetitions/UpcomingCompetitionTable.jsx
Outdated
Show resolved
Hide resolved
gregorbg
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much cleaner implementation of my PR a year ago (can't believe it's been that long)