Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for newcomer month #10328

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

dunkOnIT
Copy link
Contributor

@dunkOnIT dunkOnIT commented Nov 26, 2024

Questions:

  • Do we want some kind of validation on when to allow newcomer spots to be reserved? I see these options:
    1. [what I'm currently doing] just setting a constant to true/false when newcomer month comps are allowed at all
    2. Setting NEWCOMER_MONTH_START/END_DATE and checking if the comp's {start date/end date?} falls inside that range
    3. Having a boolean on the competition table to mark a comp as a newcomer comp - but I sort of prefer this being implicitly defined by whether or not there are newcomer spots reserved

@@ -17,6 +17,7 @@ export default function CompetitorLimit() {
<ConditionalSection showIf={hasLimit}>
<InputNumber id="count" min={0} />
<InputTextArea id="reason" />
<InputNumber id="newcomerReservedSpots" min={0} />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calculate and display the max number of newcomer reserved spots allowed per the 50% WCRP exception limit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant