Block unwanted file types from avatar upload #10135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FinnIckler
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
I assume we keep the defaults from https://github.com/rails/rails/blob/e6429269fd5a8a7d728557f4e7d7f82c0ad1478c/activestorage/lib/active_storage/engine.rb#L49 and don't overwrite them. If so LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the gazillion reasons to hate Apple! When switching to the new avatar backend, we introduced support for "web images" according to Rails -- which in turn basically just relies on MIME types and standards.
Apple's "High Efficiency Image Codec" somehow managed to get approved as "web image" in that standard, but those money-greedy bastards of course didn't release their codec properly. So while it's technically adhering to the standard, in practice most browsers don't support it because they don't know how to decode the image stream client-side.
Now we have to fall back to hard-blocking HEIC files, sigh...