Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic implementation to block banned user Discourse SSO #10121

Merged
merged 7 commits into from
Oct 29, 2024

Conversation

dunkOnIT
Copy link
Contributor

This is a very manual and blunt method - reasoning as follows:

  1. WIC has waited a long time for this feature, and there are competitor safety concerns that should be addressed
  2. I think a more elegeant solution will probably take a couple of weeks of deliberation, given that it is neither high priority nor trivial to change.

Suggested Changes to Handling of Banned Competitors

Expanding on (2) above, currently we have an enum which defines the scope of a user's ban. I think an enum is the wrong approach because it scales badly if we need to add more scopes (there are n! permutations, I think). Very reasonably, we could have the following scopes:

  • forums
  • attending
  • competing
  • staffing

Which leads to like ~10 permutations or something (given that attending would cover competing and staffing).

Instead, I think we should have a boolean column for each ban scope, and let WIC set these as they desire. (With perhaps some logic to automatically tick mark competing and staffing as true if attending is selected).

Assuming we agree on this design, it will require:

  1. Confirmation with WIC (should be quick)
  2. Migration for the banned_competitor_metadata model
  3. Population of the ban scopes for banned competitors
  4. Change to the banned competitors list display to show scopes not enums
  5. Change to the ban competitor interface to show scopes not enums

None of this is impossible, but I don't think we'll get it all done this week, and having a hotfix in place in the meantime will remove some of the pressure. I am still happy to take responsibility for making sure that our temporary solution stays temporary, though.

@FinnIckler
Copy link
Member

Do you want to add a starburst alert to signal to users that they are banned?

@dunkOnIT
Copy link
Contributor Author

Good idea - starburst added

@dunkOnIT
Copy link
Contributor Author

@thewca-bot deploy staging

@dunkOnIT dunkOnIT merged commit 78e383a into thewca:main Oct 29, 2024
2 checks passed
@dunkOnIT dunkOnIT deleted the hotfix/forum-bans branch October 29, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants