Basic implementation to block banned user Discourse SSO #10121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very manual and blunt method - reasoning as follows:
Suggested Changes to Handling of Banned Competitors
Expanding on (2) above, currently we have an enum which defines the scope of a user's ban. I think an enum is the wrong approach because it scales badly if we need to add more scopes (there are n! permutations, I think). Very reasonably, we could have the following scopes:
Which leads to like ~10 permutations or something (given that attending would cover competing and staffing).
Instead, I think we should have a boolean column for each ban scope, and let WIC set these as they desire. (With perhaps some logic to automatically tick mark
competing
andstaffing
as true ifattending
is selected).Assuming we agree on this design, it will require:
None of this is impossible, but I don't think we'll get it all done this week, and having a hotfix in place in the meantime will remove some of the pressure. I am still happy to take responsibility for making sure that our temporary solution stays temporary, though.