Distinguish between V1 and V2 competitions for Competition ID changes (…

…#10092)

* Read V2 registration usage from form state

* Allow pre-registrations for V1 or otherwise for announced comps only

* Disable frontend ID change based on V1 or V2 status

app/models/competition.rb

@@ -614,7 +614,14 @@ def info_for(user)
   end
 
   def user_can_pre_register?(user)
-    (delegates.include?(user) || trainee_delegates.include?(user) || organizers.include?(user)) && self.confirmed_or_visible?
+    # The user has to be either a registered Delegate or organizer of the competition
+    is_competition_manager = delegates.include?(user) || trainee_delegates.include?(user) || organizers.include?(user)
+    # We allow pre-registration at any time for the old registration system (because we have control over the foreign keys there)
+    #   Otherwise, if it's using the new system, we only allow registrations when it's announced
+    #   because the probability of an ID change is pretty low in that case and when it does happen, WST can handle it
+    system_compatible = !uses_new_registration_service? || announced?
+
+    is_competition_manager && system_compatible
   end
 
   attr_accessor :being_cloned_from_id

app/views/competitions/_competition_form.html.erb

@@ -2,7 +2,6 @@
 
 <%= react_component("CompetitionForm", {
   competition: @competition.to_form_data,
-  usesV2Registrations: @competition.uses_v2_registrations,
   canChangeRegistrationSystem: @competition.can_change_registration_system?,
   hasAnyRegistrations: @competition.any_registrations?,
   storedEvents: @competition.events,

app/webpacker/components/CompetitionForm/FormSections/EventRestrictions.js

@@ -14,7 +14,6 @@ import { useFormObject } from '../../wca/FormBuilder/provider/FormObjectProvider
 
 export default function EventRestrictions() {
   const {
-    usesV2Registrations,
     isCloning,
     isPersisted,
     storedEvents,
@@ -27,6 +26,9 @@ export default function EventRestrictions() {
       qualificationResults,
       eventLimitation,
     },
+    admin: {
+      usesV2Registrations,
+    },
   } = useFormObject();
 
   const mainEventOptions = useMemo(() => {

app/webpacker/components/CompetitionForm/FormSections/NameDetails.js

@@ -8,14 +8,18 @@ import { useFormObject } from '../../wca/FormBuilder/provider/FormObjectProvider
 export default function NameDetails() {
   const { hasAnyRegistrations, isPersisted, isAdminView } = useStore();
 
-  const { name } = useFormObject();
+  const { name, admin: { usesV2Registrations } } = useFormObject();
 
   const nameAlreadyShort = !name || name.length <= competitionMaxShortNameLength;
   const disableIdAndShortName = !isAdminView && nameAlreadyShort;
 
+  // ID change on V1 is always possible, because we have control over the Foreign Keys.
+  // Otherwise, only competitions without registrations can change their ID.
+  const regSystemSupportsIdChange = !usesV2Registrations || !hasAnyRegistrations;
+
   return (
     <>
-      {isPersisted && <InputString id="competitionId" disabled={disableIdAndShortName || hasAnyRegistrations} />}
+      {isPersisted && <InputString id="competitionId" disabled={disableIdAndShortName || !regSystemSupportsIdChange} />}
       <InputString id="name" required />
       {isPersisted && (
         <InputString

app/webpacker/components/CompetitionForm/index.js

@@ -75,7 +75,6 @@ function CompetitionForm() {
 
 export default function Wrapper({
   competition = null,
-  usesV2Registrations = false,
   canChangeRegistrationSystem = false,
   hasAnyRegistrations = false,
   storedEvents = [],
@@ -104,7 +103,6 @@ export default function Wrapper({
     <StoreProvider
       reducer={_.identity}
       initialState={{
-        usesV2Registrations,
         canChangeRegistrationSystem,
         hasAnyRegistrations,
         storedEvents,