-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate wca-edudoc style into compiler toolchain #120
Conversation
find 'documents' -name '*.md' | while read file; do | ||
echo "Processing $file, vanilla style" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want log messages? I found them extremely helpful during development, and with multiple folder structures I think they would be beneficial during deployment as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitely don't mind having that, the travis log is pretty short anyway.
|
||
# Find educational Markdown files and build PDFs out of them. | ||
find 'edudoc' -name '*.md' | while read file; do | ||
echo "Processing $file, edudoc style" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For log output, please see my other comment at L7: https://github.com/thewca/wca-documents/pull/120/files#r344507366
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the code looks pretty good to me, I'll test that locally to see if the build branch ends up in the state we discuss, and I'll work on the website-related pr before formally approving that!
cp -r documents build | ||
find build -name '*.md' -exec rm {} + | ||
find documents -name '*.pdf' -exec rm {} + | ||
# Create build dir so that the following cp operations maintain folder structure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For anyone else reading this: this requires some slight changes on the WCA website side of things, on which I'll work.
6a2bf69
to
c2b7514
Compare
I have added a fix for embedding images, because the path resolution used by # deliberately NOT using the pipe | operator here because wkhtml tries to resolve image links
# based on the location of its input file. If piping is used, wkhtml assumes /tmp as location
# and links like "./dummy-image.png" become "/tmp/dummy-image.png" instead of "edudoc/$project/dummy-image.png" This means we now produce an intermediate |
Let us know when this is ready to be merged so that the Board can provide the approving review. |
I just pushed @leonopulos updates, it's not finished though. |
…a couple small fixes to the header and css.
Superseded by #154. |
Porting of the format used for https://github.com/suushiemaniac/wca-edudoc into the official documents repo.
Basically introduces a second loop that uses a different CSS stylesheet for
wkhtml
as well as custom headers and footers. The principle architecture has been discussed with and approved by @viroulep.In particular, this PR will slightly change the structure of the
build/
folder: Instead of directly replicating the contents inside thedocuments/
folder it instead copies the folder as a whole so that we will now have:This change is for the website to be able to differentiate which documents to link on which page (in an upcoming PR)
I have also included the current working state of the competitor tutorial at my
wca-edudoc
repo as a sanity check.