Audio: TDFB: Tune: Updates for blobs for ALSA ucm2 control #9711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgirdwood
reviewed
Dec 5, 2024
| @@ -53,8 +53,8 @@ | |||
| bf.sofctl3_fn = fullfile(bf.sofctl3_path, sprintf('coef_%s.txt', idstr)); | |||
| bf.tplg1_fn = fullfile(bf.tplg1_path, sprintf('coef_%s.m4', idstr)); | |||
| bf.sofctl4_fn = fullfile(bf.sofctl4_path, sprintf('%s.txt', idstr)); | |||
| bf.ucmbin3_fn = fullfile(bf.sofctl3_path, sprintf('%s.bin', idstr)); | |||
| bf.ucmbin4_fn = fullfile(bf.sofctl4_path, sprintf('%s.bin', idstr)); | |||
| bf.ucmbin3_fn = fullfile(bf.sofctl3_path, sprintf('%s.blob', idstr)); | |||
There was a problem hiding this comment.
I started with UCM with .blob and thought that maybe best to have the same for all blobs instead of .bin. Would .bin be better? I have no idea really but unifying them should be good.
There was a problem hiding this comment.
yes, pls do unify. .bin is more obvious its a binary.
There was a problem hiding this comment.
Yep. I dropped the commit for rename, and will change the few blobs in UCM side instead.
This change adds to exported blobs for ucm2 usage more angles. The angles selectable from user space are for stereo capture +/- 5/15/30/90 degrees. The zero degrees beam is changed to plus/minus degrees to provide some stereo sensation instead of mono. Signed-off-by: Seppo Ingalsuo <[email protected]>
singalsu
force-pushed
the
tdfb_ucm_blobs_export_update
branch
from
5bc6a4f to
bec60b0
Compare
lgirdwood
approved these changes
Dec 10, 2024
kv2019i
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.