Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xtensa-build-zephyr.py: fix error message. Simplify and clarify cadence environment variables #8890

Merged
merged 4 commits into from
Mar 1, 2024

Conversation

marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Feb 29, 2024

4 commits, see commit messages.

Like most error handling, the exception was never tested and the error
message was wrong.

Signed-off-by: Marc Herbert <[email protected]>
Remove unnecessary complexities in the Python code.

Document all variables in the comments.

Signed-off-by: Marc Herbert <[email protected]>
Pure formatting simplification, zero logical change.

Signed-off-by: Marc Herbert <[email protected]>
This has always been mysterious, try to shed a bit of light.

Signed-off-by: Marc Herbert <[email protected]>
@marc-hb
Copy link
Collaborator Author

marc-hb commented Feb 29, 2024

https://sof-ci.01.org/sof-pr-viewer/#/build/PR8890/build13647991 is green.

CAVS https://sof-ci.01.org/sofpr/PR8890/build2992/devicetest/index.html has only one suspend/resume failure.

ACE https://sof-ci.01.org/sofpr/PR8890/build2991/devicetest/index.html?model=MTLP_SDW_AIOC&testcase=check-kmod-load-unload has only one failure on sh-mtlp-rvp-sdw-03 but one I have never seen before: rmmod: ERROR: Module snd_usb_audio is in use

Very strange but totally unrelated to this pure xtensa-build-zephyr.py change.

@marc-hb

This comment was marked as outdated.

@marc-hb
Copy link
Collaborator Author

marc-hb commented Feb 29, 2024

The errors did not actually matter. What matters is: pipewire keeps snd_usb_audio busy at all times. Solved with systemctl --user mask --now pipewire

@marc-hb

This comment was marked as outdated.

@marc-hb
Copy link
Collaborator Author

marc-hb commented Feb 29, 2024

@lgirdwood lgirdwood merged commit 1b0c084 into thesofproject:main Mar 1, 2024
40 of 44 checks passed
@marc-hb marc-hb deleted the clarify-cadence-vars branch March 13, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants