Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config L3_HEAP: add missing "ACE" dependency #8827

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Feb 2, 2024

Current commit message:

In Zephyr, L3_HEAP is available in intel_ace15_mtpm/adsp_memory.h and
intel_ace20_lnl/adsp_memory.h but not in intel_tgl_adsp/adsp_memory.h

Don't allow configuration that can't possible compile.

Signed-off-by: Marc Herbert [email protected]

@marc-hb marc-hb marked this pull request as ready for review February 2, 2024 06:38
@marc-hb marc-hb requested a review from jxstelter February 2, 2024 06:38
lyakh
lyakh previously requested changes Feb 2, 2024
Copy link
Collaborator

@lyakh lyakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something isn't right here, at least in the commit description: I see adsp_memory.h included in src/platform/tigerlake/include/platform/lib/memory.h.
Could you clarify which files, enabled by L3_HEAP include adsp_memory.h? In my local (almost current) tree I only see adsp_memory.h included in src/ipc/ipc4/helper.c, in zephyr/include/sof/lib/regions_mm.h and in src/platform/${platform}/include/platform/lib/memory.h

@marc-hb
Copy link
Collaborator Author

marc-hb commented Feb 2, 2024

Could you clarify which files, enabled by L3_HEAP include adsp_memory.h?

Sorry I should have written something like: "L3_HEAP is currently available in adsp_memory.h only for ace15 and ace20". Would that work for you?

@lgirdwood
Copy link
Member

Btw, is there no prefix on ACE ? It seems like this will collide at some point. What does Zephyr use here for this IP version ?

@marc-hb
Copy link
Collaborator Author

marc-hb commented Feb 28, 2024

Btw, is there no prefix on ACE ?

Not right now.

It seems like this will collide at some point.

Zephyr symbols for hardware tend to be much longer so it won't collide unless some generic feature is called "ACE" in the future.

What does Zephyr use here for this IP version ?

I found CONFIG_SOC_SERIES_INTEL_ACE but I suspect the incoming hwmv2 (Hardware Model v2) might change things.

In Zephyr, L3_HEAP is available in `intel_ace15_mtpm/adsp_memory.h` and
`intel_ace20_lnl/adsp_memory.h` but not in `intel_tgl_adsp/adsp_memory.h`

Don't allow configuration that can't possible compile.

Signed-off-by: Marc Herbert <[email protected]>
@marc-hb
Copy link
Collaborator Author

marc-hb commented Feb 28, 2024

The PUBLISH step failed as usual today but all the tests passed in https://sof-ci.01.org/sof-pr-viewer/#/build/PR8827/build13641692

@marc-hb marc-hb requested a review from tmleman February 28, 2024 03:10
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, we need to revisit all the Kconfig and API common names we have and prefix them for v2.10.

@kv2019i kv2019i merged commit 60f517c into thesofproject:main Mar 5, 2024
40 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants