-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config L3_HEAP: add missing "ACE" dependency #8827
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something isn't right here, at least in the commit description: I see adsp_memory.h included in src/platform/tigerlake/include/platform/lib/memory.h.
Could you clarify which files, enabled by L3_HEAP
include adsp_memory.h? In my local (almost current) tree I only see adsp_memory.h included in src/ipc/ipc4/helper.c, in zephyr/include/sof/lib/regions_mm.h and in src/platform/${platform}/include/platform/lib/memory.h
Sorry I should have written something like: "L3_HEAP is currently available in adsp_memory.h only for ace15 and ace20". Would that work for you? |
Btw, is there no prefix on |
Not right now.
Zephyr symbols for hardware tend to be much longer so it won't collide unless some generic feature is called "ACE" in the future.
I found |
In Zephyr, L3_HEAP is available in `intel_ace15_mtpm/adsp_memory.h` and `intel_ace20_lnl/adsp_memory.h` but not in `intel_tgl_adsp/adsp_memory.h` Don't allow configuration that can't possible compile. Signed-off-by: Marc Herbert <[email protected]>
The PUBLISH step failed as usual today but all the tests passed in https://sof-ci.01.org/sof-pr-viewer/#/build/PR8827/build13641692 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, we need to revisit all the Kconfig and API common names we have and prefix them for v2.10.
Current commit message:
In Zephyr, L3_HEAP is available in
intel_ace15_mtpm/adsp_memory.h
andintel_ace20_lnl/adsp_memory.h
but not inintel_tgl_adsp/adsp_memory.h
Don't allow configuration that can't possible compile.
Signed-off-by: Marc Herbert [email protected]