Loadable up down mixer #8667
Loadable up down mixer #8667
Conversation
pjdobrowolski
force-pushed
the
loadable_up_down_mixer
branch
from
27a5d7e to
7cc09b3
Compare
| load_offset = "0x40000" | ||
|
|
||
| [module] | ||
| count = 1 |
There was a problem hiding this comment.
no, all this must not be here.
There was a problem hiding this comment.
Where can it be more suitable place to leave that toml?
There was a problem hiding this comment.
Where can it be more suitable place to leave that toml?
sorry, I meant that specific part that you're adding here. It's platform specific and it should be in a suitable .toml and they should be merged together by the C preprocessor similar to how https://github.com/thesofproject/sof/blob/main/tools/rimage/config/mtl.toml.h currently includes all module toml files
pjdobrowolski
force-pushed
the
loadable_up_down_mixer
branch
from
7cc09b3 to
5e9f9db
Compare
pjdobrowolski
requested review from
akloniex,
kv2019i,
iuliana-prodan,
dbaluta,
abonislawski,
RanderWang,
marcinszkudlinski,
pblaszko,
lgirdwood,
plbossart,
mmaka1 and
lbetlej
as code owners
|
@pjdobrowolski are you using a 3rd party binary for the mixer OR just the code we have in the SOF repo? Or, does it matter? |
This is the example how to convert up_down_mixer from SOF repo to loadable version. Only requirement for conversion is to set UPDWMIX to know in configuration to exclude up_down_mixer from build_in modules. |
| @@ -0,0 +1,86 @@ | |||
| version = [3, 0] | |||
There was a problem hiding this comment.
why is this file needed, and particularly in this PR?
There was a problem hiding this comment.
toml is modular now, so we can take the up/down mixer parts in the correct place.
You are welcome. |
| @@ -0,0 +1,86 @@ | |||
| version = [3, 0] | |||
There was a problem hiding this comment.
toml is modular now, so we can take the up/down mixer parts in the correct place.
pjdobrowolski
force-pushed
the
loadable_up_down_mixer
branch
from
5e9f9db to
65dbf89
Compare
|
Changed to draft, module will be moved to https://github.com/thesofproject/converged-sof-modules |
pjdobrowolski
force-pushed
the
loadable_up_down_mixer
branch
from
421536b to
109843b
Compare
No, this repo was temporary and for staging only prior to module API, IPC4 etc being upstream in main. All the dependencies are now upstream so all library support should go upstream. We also cannot duplicate our modules in two places. This repo will be moving to archived state, there is no need to keep it today. |
pjdobrowolski
force-pushed
the
loadable_up_down_mixer
branch
2 times, most recently
from
d565c36 to
5ff7f2b
Compare
pjdobrowolski
force-pushed
the
loadable_up_down_mixer
branch
from
5ff7f2b to
f0ccf30
Compare
|
Ok, I removed all unnecessary MODULE_PRIVAT tags and created exported headers from sof. Now up_down_mixer is building outside of sof. @softwarecki now we must create some kind of git/python verification script to check if these headers change or what happen with them for ABI verification. |
|
please check #8554. We don't need to copy headers to lmdk. |
|
llext and native loadable modules are not the same. |
@pjdobrowolski what @RanderWang is talking about isn't an LLEXT module, it's what you call a "native" system-service module, that he has submitted, you still don't need to copy headers for those |
pjdobrowolski
force-pushed
the
loadable_up_down_mixer
branch
from
f0ccf30 to
d05c03c
Compare
Not all headers and funtions are used in loadable modules that is why we need for smaller header packs reduce it to what is truely need. Signed-off-by: Dobrowolski, PawelX <[email protected]>
Example of loadable module build using lmdk Signed-off-by: Dobrowolski, PawelX <[email protected]>
pjdobrowolski
force-pushed
the
loadable_up_down_mixer
branch
from
5a4f512 to
651dea1
Compare
This is an module_example of loadable up_down_mixer with lmdk.