rimage/smex: code improvements / fixes #8604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
read module function should only read module, additional free operation could result in double free scenario Signed-off-by: Adrian Bonislawski <[email protected]>
Validate section ptr Signed-off-by: Adrian Bonislawski <[email protected]>
this will fix parameter order to: size, count Signed-off-by: Adrian Bonislawski <[email protected]>
Check fwrite status for error Signed-off-by: Adrian Bonislawski <[email protected]>
Check fwrite status for error Signed-off-by: Adrian Bonislawski <[email protected]>
remove logically dead code Signed-off-by: Adrian Bonislawski <[email protected]>
Fixes commit #e5f337ba70a5 Signed-off-by: Adrian Bonislawski <[email protected]>
Fixes error handling Signed-off-by: Adrian Bonislawski <[email protected]>
abonislawski
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej and
dbaluta
as code owners
kv2019i
approved these changes
Dec 11, 2023
tmleman
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick from MTL-007 branch
Mainly fixes for scan errors