Fixes for compilation errors with the SOF plugin #8489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a couple of missing definitions. Signed-off-by: Ranjani Sridharan <[email protected]>
Make the mixout bind/unbind functions static. Signed-off-by: Ranjani Sridharan <[email protected]>
…ERS is not set Use 2 separate signatures when CONFIG_ZEPHYR_NATIVE_DRIVERS is set vs not set. Signed-off-by: Ranjani Sridharan <[email protected]>
These dont exist anymore. Signed-off-by: Ranjani Sridharan <[email protected]>
…IG_LIBRARY is set This is already defined in logging.c when a known logging method is not set. Signed-off-by: Ranjani Sridharan <[email protected]>
Fix the typecasting in a couple of places and compiler attributes to
prevent the following compilation errors:
ipc4/handler.c:1007:45: error: pointer targets in initialization of ‘const uint8_t *’
{aka ‘const unsigned char *’} from ‘const char *’ differ in signedness [-Werror=pointer-sign]
1007 | const uint8_t *end_offset = data + data_off_size;
| ^~~~
ipc4/handler.c:1040:57: note: expected ‘const char *’ but argument is of type ‘uint8_t *’ {aka ‘unsigned char *’}
ipc4/module.h:67:12: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘__aligned’
67 | } __packed __aligned(4);
Signed-off-by: Ranjani Sridharan <[email protected]>
ranj063
requested review from
RanderWang,
marcinszkudlinski,
pblaszko,
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
lgirdwood
approved these changes
Nov 17, 2023
btian1
reviewed
Nov 20, 2023
| @@ -64,7 +64,7 @@ union ipc4_extended_param_id { | |||
| uint32_t parameter_type : 8; | |||
| uint32_t parameter_instance : 24; | |||
| } part; | |||
| } __packed __aligned(4); | |||
| } __attribute__((packed, aligned(4))); | |||
There was a problem hiding this comment.
I noticed kernel use left expression for alignment, and sof fw use right ones, any history on this?
There was a problem hiding this comment.
"__packed" is a linux kernel shortcut, not necessarily available in generic toolchains (like for SOF plugin).
kv2019i
approved these changes
Nov 20, 2023
| @@ -64,7 +64,7 @@ union ipc4_extended_param_id { | |||
| uint32_t parameter_type : 8; | |||
| uint32_t parameter_instance : 24; | |||
| } part; | |||
| } __packed __aligned(4); | |||
| } __attribute__((packed, aligned(4))); | |||
There was a problem hiding this comment.
"__packed" is a linux kernel shortcut, not necessarily available in generic toolchains (like for SOF plugin).
|
@lrudyX any update on the rerun ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.