-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EQ FIR code re-organize #8436
EQ FIR code re-organize #8436
Conversation
This is part of eq_fir code reorganize, move headers to its own directory. Signed-off-by: Baofeng Tian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds eight new C files to zephyr/CMakeLists.txt
but it does not seem to remove them from anywhere else. So how is this a "re-org"? Please explain in the commit message what is happening here.
74efa04
to
524154b
Compare
Move out ipc3 and ipc4 specific code to corresponding source file. Also, move some common functions to header file. Signed-off-by: Baofeng Tian <[email protected]>
Simplify set parameters, also add source buffer parameter setting. Signed-off-by: Baofeng Tian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, lets address @singalsu and I think we are good to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for the clean up work!
No description provided.