Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EQ FIR code re-organize #8436

Merged
merged 3 commits into from
Nov 16, 2023
Merged

EQ FIR code re-organize #8436

merged 3 commits into from
Nov 16, 2023

Conversation

btian1
Copy link
Contributor

@btian1 btian1 commented Nov 3, 2023

No description provided.

This is part of eq_fir code reorganize, move headers to
its own directory.

Signed-off-by: Baofeng Tian <[email protected]>
@btian1 btian1 marked this pull request as ready for review November 6, 2023 02:23
marc-hb
marc-hb previously requested changes Nov 7, 2023
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds eight new C files to zephyr/CMakeLists.txt but it does not seem to remove them from anywhere else. So how is this a "re-org"? Please explain in the commit message what is happening here.

zephyr/CMakeLists.txt Outdated Show resolved Hide resolved
src/audio/eq_fir/eq_fir_ipc3.c Show resolved Hide resolved
src/audio/eq_fir/eq_fir_ipc4.c Show resolved Hide resolved
@btian1 btian1 force-pushed the fir_refine branch 2 times, most recently from 74efa04 to 524154b Compare November 8, 2023 03:04
src/audio/eq_fir/eq_fir_ipc3.c Show resolved Hide resolved
src/audio/eq_fir/eq_fir_ipc3.c Show resolved Hide resolved
src/audio/eq_fir/eq_fir_ipc3.c Show resolved Hide resolved
@marc-hb marc-hb dismissed their stale review November 8, 2023 17:35

Cmake duplication removed

Move out ipc3 and ipc4 specific code to corresponding source file.
Also, move some common functions to header file.

Signed-off-by: Baofeng Tian <[email protected]>
src/audio/eq_fir/eq_fir_ipc4.c Show resolved Hide resolved
src/audio/eq_fir/eq_fir_ipc4.c Outdated Show resolved Hide resolved
Simplify set parameters, also add source buffer parameter setting.

Signed-off-by: Baofeng Tian <[email protected]>
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets address @singalsu and I think we are good to merge.

@lgirdwood lgirdwood added this to the v2.8 milestone Nov 13, 2023
Copy link
Collaborator

@singalsu singalsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the clean up work!

@kv2019i kv2019i merged commit 81398b0 into thesofproject:main Nov 16, 2023
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants