topology2: deep-buffer: Add second instance #8430
Conversation
| } | ||
| Object.Widget.gain.1 { | ||
| Object.Control.mixer.1 { | ||
| name 'Deepbuffer 2 Volume' |
There was a problem hiding this comment.
probably best to find a different name with a parameter
|
V2 update:
|
| "true" { | ||
| Object.Pipeline.deepbuffer-playback [ | ||
| { | ||
| index $DEEP_BUFFER_PIPELINE_ID_2 |
There was a problem hiding this comment.
where is this defined? Don't you need defaults for this and all the *_2's below?
There was a problem hiding this comment.
I am thinking to add those in the parent conf (ie cavs_rt5682.c) in another patch with DEEP_BUF_2=true for the target tplg:
+ DEEP_BUFFER_PIPELINE_ID_2 35
+ DEEP_BUFFER_PCM_ID_2 51
+ DEEP_BUFFER_PIPELINE_SRC_2 'mixin.35.1'
+ DEEP_BUFFER_PIPELINE_SINK_2 'mixout.4.1'
+ DEEP_BUFFER_PCM_NAME_2 'Deepbuffer Amps'
yongzhi1
force-pushed
the
db2
branch
2 times, most recently
from
7e9af58 to
7d1a8e9
Compare
|
V3 update:
|
| @@ -57,14 +57,14 @@ PDM1_MIC_B_ENABLE=1,DMIC0_PCM_ID=99,PREPROCESS_PLUGINS=nhlt,\ | |||
| NHLT_BIN=nhlt-sof-mtl-max98357a-rt5682.bin,DEEPBUFFER_FW_DMA_MS=10,HEADSET_SSP_DAI_INDEX=2,\ | |||
| SPK_ID=6,SPEAKER_SSP_DAI_INDEX=0,HEADSET_CODEC_NAME=SSP2-Codec,SPEAKER_CODEC_NAME=SSP0-Codec,\ | |||
| BT_NAME=SSP1-BT,BT_INDEX=1,BT_ID=7,BT_PCM_NAME=Bluetooth,INCLUDE_ECHO_REF=true,USE_CHAIN_DMA=true,\ | |||
| DEEPBUFFER_D0I3_COMPATIBLE=true,GOOGLE_RTC_AEC_SUPPORT=1" | |||
| DEEPBUFFER_D0I3_COMPATIBLE=true,GOOGLE_RTC_AEC_SUPPORT=1,DEEP_BUF_2=true" | |||
There was a problem hiding this comment.
Long term, we need a better name or flag to say a PCM is deep buffer i.e. DEEP_BUFFER_HP=true. Not a blocker for this PR though, can be looked at later.
There was a problem hiding this comment.
+1. DEEP_BUFFER_HP=true & DEEP_BUFFER_SPK= true gives better understanding
There was a problem hiding this comment.
Ack, will update DEEP_BUFFER_2 to DEEP_BUFFER_SPK.
so far we have single deepbuf PCM, DEEPBUFFER_FW_DMA_MS is used to represent DEEP_BUFFER_HP, can we use a seperate PR to add DEEP_BUFFER_HP since it will touch more files? Thanks,
Add 2nd deepbuff PCM as an option. Signed-off-by: Yong Zhi <[email protected]>
Add deep buffer PCM35 on amps for sof-mtl-max98357a-rt5682 tplg. Signed-off-by: Yong Zhi <[email protected]>
|
UPDATE:
|
Add 2nd deepbuff PCM as an option.