Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Src format condense in tplg file #8352

Merged
merged 5 commits into from
Oct 27, 2023
Merged

Src format condense in tplg file #8352

merged 5 commits into from
Oct 27, 2023

Conversation

btian1
Copy link
Contributor

@btian1 btian1 commented Oct 19, 2023

No description provided.

ranj063
ranj063 reviewed Oct 19, 2023
View reviewed changes
tools/topology/topology2/include/components/src_format_s32_convert_from_48k.conf Show resolved Hide resolved
tools/topology/topology2/include/components/src_format_s32_to_sxx_convert.conf Show resolved Hide resolved
tools/topology/topology2/include/components/src_format_sxx_to_s32_convert.conf Outdated
32
]
in_valid_bit_depth [
16
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same thing here. cannot combine the values of 16/32 for bit_depth with 16/24/32 for valid bit depth

tools/topology/topology2/include/components/src_format_sxx_to_s32_convert.conf Show resolved Hide resolved
@btian1 btian1 force-pushed the src_format_condense branch 4 times, most recently from c266584 to c25623c Compare October 20, 2023 13:52
@btian1 btian1 force-pushed the src_format_condense branch from c25623c to 3b34f58 Compare October 23, 2023 02:27
@btian1 btian1 marked this pull request as ready for review October 23, 2023 03:04
@btian1 btian1 requested a review from jsarha as a code owner October 23, 2023 03:04
@btian1
Copy link
Contributor Author

btian1 commented Oct 24, 2023

SOFCI TEST

lgirdwood
lgirdwood approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@singalsu @andrula-song pls review for SRC config.
@btian1 ack - we can follow up obs/ibs alignment in next PR.

kv2019i
kv2019i requested changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd at least want @singalsu to ack this before merge as this seems to change the formula.

tools/topology/topology2/include/components/src_format_s32_convert_from_48k.conf Show resolved Hide resolved
@btian1 btian1 requested a review from andrula-song October 26, 2023 01:34
andrula-song
andrula-song reviewed Oct 26, 2023
View reviewed changes
tools/topology/topology2/include/components/src_format_s32_convert_from_48k.conf Outdated
{
out_rate [
8000
11025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we put this 11.025kHz to the next group?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder why 22050 does not have obs setting @singalsu

@btian1 btian1 force-pushed the src_format_condense branch from 3b34f58 to e4b5920 Compare October 26, 2023 05:29
btian1 added 5 commits October 26, 2023 13:42
@btian1
Topology2: condense output format in tplg file
77a12d5 
Condense src 48k to other audio format with combined array format.

Signed-off-by: Baofeng Tian <[email protected]>
@btian1
Topology2: condense src input format in tplg file
54933e4 
Condense src input audio format convert to 48k in tplg file.

Signed-off-by: Baofeng Tian <[email protected]>
@btian1
Topology2: condense tplg audio format for s32 format
c4d8e19 
Condense src format from s32 to multiple audio format.

Signed-off-by: Baofeng Tian <[email protected]>
@btian1
Topology2: condense src input format with combined array
76ce1fb 
Condense input format to combined array for src.

Signed-off-by: Baofeng Tian <[email protected]>
@btian1
Topology2: condense passthrough tplg file audio format
e4b5920 
Condense passthrough audio format with combined arrays.

Signed-off-by: Baofeng Tian <[email protected]>
@btian1
Copy link
Contributor Author

btian1 commented Oct 27, 2023

@singalsu , please review this combined SRC tplg PR.
Btw, please confirm in first patch, there may have a missed obs setting bug for 22050hz, I will try to fix it and re-calculate obs in next PR.

singalsu
singalsu requested changes Oct 27, 2023
View reviewed changes
tools/topology/topology2/include/components/src_format_s32_convert_from_48k.conf
44100
88200
176400
]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 22050 should also belong here because the 1 ms period does not have integer samples count. It's missing from original topology, but it looks it has been missed.

singalsu
singalsu approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@singalsu singalsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed my mind, this produces same formats tables as before. Yes please use the same equation for 22050 Hz in next PR as for other 44.1 kHz family rates.

@kv2019i kv2019i merged commit e20009b into thesofproject:main Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrula-song andrula-song andrula-song left review comments

@ranj063 ranj063 ranj063 approved these changes

@kv2019i kv2019i kv2019i approved these changes

@singalsu singalsu singalsu approved these changes

@lgirdwood lgirdwood lgirdwood approved these changes

@jsarha jsarha Awaiting requested review from jsarha jsarha is a code owner

@marcinszkudlinski marcinszkudlinski Awaiting requested review from marcinszkudlinski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@btian1 @ranj063 @lgirdwood @singalsu @kv2019i @marcinszkudlinski @andrula-song